[Spark plugin] Fix environment variable ValueFrom for pod templates #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Newton <[email protected]>
…vVars Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
dosubot
bot
added
the
size:M
Tom-Newton
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4532 +/- ##
=======================================
Coverage 58.89% 58.89%
=======================================
Files 620 620
Lines 52458 52458
=======================================
Hits 30895 30895
- Misses 19095 19096 +1
+ Partials 2468 2467 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tom-Newton
changed the title
hamersaw
approved these changes
Dec 6, 2023
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
…4532) * Update tests Signed-off-by: Thomas Newton <[email protected]> * Use Copy Container.Env to SparkPodSpec.Env instead of SparkPodSpec.EnvVars Signed-off-by: Thomas Newton <[email protected]> * Fix list initialisation Signed-off-by: Thomas Newton <[email protected]> --------- Signed-off-by: Thomas Newton <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4530
Why are the changes needed?
To support using ValueFrom for environment variables configured in pod templates.
What changes were proposed in this pull request?
Put
Container.Envfrom the pod template intoSparkPodSpec.Envinstead ofSparkPodSpec.EnvVars.This means all the ValueFrom features of
corev1.EnvVarshould be supported.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link